Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warning for python 3.8 #2520

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Deprecation warning for python 3.8 #2520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f8b6ae
Deprecation warning for python 3.8
ADBond Nov 4, 2024
487aad6
update changelog with deprecation
ADBond Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Various bugfixes for `debug_mode` ([#2481](https://github.com/moj-analytical-services/splink/pull/2481))
- Clustering still works in DuckDB even if no edges are available ([#2510](https://github.com/moj-analytical-services/splink/pull/2510))

## Deprecated

- Deprecated support for python `3.8.x` following end of support for that minor version ([#2520](https://github.com/moj-analytical-services/splink/pull/2520))

## [4.0.5] - 2024-11-06

### Fixed
Expand Down
15 changes: 15 additions & 0 deletions splink/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
from sys import version_info
from typing import TYPE_CHECKING
from warnings import warn

from splink.internals.blocking_rule_library import block_on
from splink.internals.column_expression import ColumnExpression
Expand All @@ -17,6 +19,19 @@
from splink.internals.duckdb.database_api import DuckDBAPI
from splink.internals.spark.database_api import SparkAPI

if version_info.minor == 8:
warn(
(
"Python 3.8 has reached end-of-life. "
"Future releases of Splink may no longer be compatible with "
"this python version.\n"
"Please consider upgrading your python version if you wish "
"to continue to be able to install the latest version of Splink."
),
category=DeprecationWarning,
stacklevel=2,
)


# Use getarr to make the error appear at the point of use
def __getattr__(name):
Expand Down
Loading