Simplify Altair import #2479
Merged
Simplify Altair import #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altair is a core requirement, and this fails anyway if altair not installed, just more mysteriously
|
Thanks. The history of this is that a long time ago ONS could install splink but not altair for unknown reasons. But that was years ago. Let's merge this, and then we can always restore some sort of weird workaround if ONS still need it. |
RobinL
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a slightly cryptic error if you try to use splink in an environment where Altair is not installed. I have made it so that this will give a normal error about a missing import.
There was also some code nominally to guard for the case of Altair not being installed. I have removed this as
Closes #2474.