Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhelpful error if altair not installed #2474

Closed
ADBond opened this issue Oct 16, 2024 · 0 comments · Fixed by #2479
Closed

Unhelpful error if altair not installed #2474

ADBond opened this issue Oct 16, 2024 · 0 comments · Fixed by #2479
Labels
dependencies Pull requests that update a dependency file

Comments

@ADBond
Copy link
Contributor

ADBond commented Oct 16, 2024

I used the below option but always gets this error
nam alt is not defined.

Tried installing alt but still same issue

Image

Originally posted by @aamir-rj in #2459

If users find themselves trying to run Splink in an environment where altair is not installed for some reason, they are left, on trying to import Splink, with the unclear error: NameError: name 'alt' is not defined.

This originates from splink.internals.charts as we create a type alias ChartReturnType for use both in that module and elsewhere for type hinting.

We should perhaps rework this a little, and maybe convert this to a ModuleNotFoundError to make the remedy clearer.

@ADBond ADBond added the dependencies Pull requests that update a dependency file label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant