Return non-zero exit code when any checker fails #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohlsen
approved these changes
Oct 24, 2016
| @@ -51,5 +51,6 @@ checker(process.argv[2]).then((result) => { | |||
| } | |||
| else { | |||
| console.log('\n', result.message.text.boldUnderlineError); | |||
| process.exit(1); | |||
There was a problem hiding this comment.
better to just return result.packages.length?
There was a problem hiding this comment.
If I understand the code correctly, result.packages.length would be the total number of packages/engines validated, not the number that failed validation.
I originally tried to return the number of failed validations, but was having some trouble reading the code and understanding the result object. I did this as a short putt that solved the immediate problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #33.
For now, I'm just returning 1 when any checker fails.