ZMK Rebase v23.12 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanforbes
reviewed
Nov 24, 2023
app/src/hog.c
Outdated
| } | ||
|
|
||
| struct bt_gatt_notify_params notify_params = { | ||
| .attr = &hog_svc.attrs[13], |
There was a problem hiding this comment.
This needs to be updated to .attr = &hog_svc.attrs[16],. Each BT_GATT_CHARACTERISTIC adds two items to the attrs array, so the LED report adds 3 items before the mouse items.
There was a problem hiding this comment.
Does that mean that this change (taken from the upstream PR) is also insufficient, since it only offsets the index for the consumer report by 2 rather than by 3?
There was a problem hiding this comment.
No, the consumer report upstream was added after the mouse report, so it doesn't affect the index of the mouse report
bryanforbes
reviewed
Nov 24, 2023
chrisandreae
force-pushed
the
zmk-rebase-20231119
branch
2 times, most recently
from
d463963 to
f17bd88
Compare
chrisandreae
force-pushed
the
zmk-rebase-20231119
branch
from
f17bd88 to
571d91a
Compare
chrisandreae
force-pushed
the
zmk-rebase-20231119
branch
from
571d91a to
c652138
Compare
|
Rebased to upstream ZMK 55aed8e |
chrisandreae
force-pushed
the
zmk-rebase-20231119
branch
2 times, most recently
from
74a619c to
179e6dc
Compare
chrisandreae
force-pushed
the
zmk-rebase-20231119
branch
2 times, most recently
from
d28e9fc to
c0dbb3c
Compare
chrisandreae
force-pushed
the
zmk-rebase-20231119
branch
3 times, most recently
from
08ba7d2 to
e3bf640
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebases Glove80's patchset onto upstream ZMK at d7d9eed (Wed Nov 15 11:16:59 2023 -0800).
Additionally includes in PR#11 (name Bluetooth device using serial number prefix) and PR#24 (validate devicetree root entity names when remote building).