Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

Fix 404 API spec link in README.md #941

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FifthTundraG
Copy link

https://docs.modrinth.com/api-spec/ is no longer used for the API spec and returns a 404, but the link in the README still uses the old URL. This PR fixes that and switches it to https://docs.modrinth.com/.

@FifthTundraG
Copy link
Author

It's worth noting that https://docs.modrinth.com/api-spec without a trailing backslash will redirect to the main page, but going to https://docs.modrinth.com/api-spec/ with a trailing backslash will return a 404, because it's treated as a directory instead of a file. This is probably an oversight, but I'm uncertain whether or not this would be considered an issue with the documentation's redirects or would be considered a user error. Personally, I think that since a trailing backslash worked before the restructuring of the site, it's important to ensure compatibility with older documents that still may use this link alongside a trailing backslash, which would warrant fixing this issue. I figured I should ask if this is the right move before making a contribution, though 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants