This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Switch to Trolley for Modrinth Payments #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmegaJak
reviewed
Oct 10, 2023
| if &*request_signature == v1 { | ||
| let webhook = serde_json::from_slice::<TrolleyWebhook>(&payload)?; | ||
|
|
||
| if webhook.model == "recipient" { |
There was a problem hiding this comment.
The inside of this if statement and the next one would make great separate methods (trolley_recipient_webhook and trolley_payment_webhook or something).
These several hundred line methods are not ideal
There was a problem hiding this comment.
Once that's done, that also opens the door to doing some more focused tests where we supply it with a TrolleyWebhook with data we formed to be like what we would actually get from Trolley and make sure we update the database correctly in response. This lets us test parts of this flow easily without actually integrating with Trolley.
Co-authored-by: Jackson Kruger <[email protected]>
OmegaJak
approved these changes
Oct 11, 2023
OmegaJak
reviewed
Oct 11, 2023
Co-authored-by: Jackson Kruger <[email protected]>
thesuzerain
pushed a commit
that referenced
this pull request
Dec 5, 2023
* most of trolley * Switch to trolley for payments * run prepare * fix clippy * fix more * Fix most tests + bitflags * Update src/auth/flows.rs Co-authored-by: Jackson Kruger <[email protected]> * Finish trolley * run prep for merge * Update src/queue/payouts.rs Co-authored-by: Jackson Kruger <[email protected]> --------- Co-authored-by: Jackson Kruger <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to trolley as our payout provider.
Fixes MOD-530