This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Batch inserts [MOD-555] #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesuzerain
approved these changes
Oct 11, 2023
Geometrically
approved these changes
Oct 11, 2023
thesuzerain
pushed a commit
that referenced
this pull request
Dec 5, 2023
* Batch a bunch of inserts, but still more to do * Insert many for clickhouse (+ tests) * Batch the remaining ones except those requiring deduplication * Risky dedups * Bit o cleanup and formatting * cargo sqlx prepare * Add test around batch editing project categories * Add struct to satisfy clippy * Fix silly mistake that was caught by the tests! * Leave room for growth in dummy_data
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert all instances of inserts being done inside for loops that I could find (excluding doubly nested or other extra gnarly scenarios) into using batch inserts in the way currently recommended by Sqlx.
Most of the changes are pretty straightforward transformations where I replaced the for loop with an iterator statement that produces a vec per column. A few others were a bit more involved:
routes/v2/projects.rsaround category insertion, so I refactored commonalities there.I also didn't touch notification inserts since that change is pending in #723.