This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Tests #719
Merged
Tests #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmegaJak
reviewed
Oct 5, 2023
OmegaJak
reviewed
Oct 5, 2023
OmegaJak
reviewed
Oct 5, 2023
OmegaJak
reviewed
Oct 5, 2023
OmegaJak
reviewed
Oct 5, 2023
OmegaJak
reviewed
Oct 5, 2023
OmegaJak
reviewed
Oct 5, 2023
OmegaJak
reviewed
Oct 5, 2023
OmegaJak
reviewed
Oct 5, 2023
OmegaJak
reviewed
Oct 5, 2023
OmegaJak
reviewed
Oct 5, 2023
Geometrically
suggested changes
Oct 5, 2023
tests/scopes.rs
Outdated
There was a problem hiding this comment.
The structure here seems a bit weird to me. I think it would be better to just test the scopes as part of other tests and have those in respective files. Since this is testing the routes anyways basically I think that structure would be better. Totally open to both ways though
There was a problem hiding this comment.
Thats fair- if its all the same I think I'll keep it this way for now given that we dont have files for all the routes yet. As we make rs files ill port them over
OmegaJak
approved these changes
Oct 6, 2023
Geometrically
approved these changes
Oct 6, 2023
thesuzerain
added a commit
that referenced
this pull request
Nov 9, 2023
* computer switch * some fixes; github action * added pr to master * sqlx database setup * switched intial GHA test db * removed sqlx database setup * unfinished patch route * bug fixes + tests * more tests, more fixes, cargo fmt * merge fixes * more tests, full reorganization * fmt, clippy * sqlx-data * revs * removed comments * delete revs
thesuzerain
added a commit
that referenced
this pull request
Dec 5, 2023
* computer switch * some fixes; github action * added pr to master * sqlx database setup * switched intial GHA test db * removed sqlx database setup * unfinished patch route * bug fixes + tests * more tests, more fixes, cargo fmt * merge fixes * more tests, full reorganization * fmt, clippy * sqlx-data * revs * removed comments * delete revs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still in draft for github actions testing alongside actual test writing.
Theoretically in the future, adds an automatic cargo test library to labrinth