This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
analytics #695
Merged
analytics #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geometrically
suggested changes
Sep 11, 2023
src/routes/v2/analytics_get.rs
Outdated
Comment on lines
239
to
254
| /// Get country data for a set of projects or versions | ||
| /// Data is returned as a hashmap of project/version ids to a hashmap of coutnry to views + downloads. | ||
| /// Unknown countries are labeled "". | ||
| /// This is usuable to see significant performing countries per project | ||
| /// eg: | ||
| /// { | ||
| /// "4N1tEhnO": { | ||
| /// "CAN": { | ||
| /// total_views: 3213 | ||
| /// total_downloads: 22 | ||
| /// } | ||
| /// } | ||
| ///} | ||
| /// Either a list of project_ids or version_ids can be used, but not both. Unauthorized projects/versions will be filtered out. | ||
| /// For this endpoint, provided dates are a range to aggregate over, not specific days to fetch | ||
| #[get("countries")] |
There was a problem hiding this comment.
I think we should separate this into separate routes based on datatype
src/routes/v2/analytics_get.rs
Outdated
| /// { | ||
| /// "4N1tEhnO": { | ||
| /// "20230824": { | ||
| /// "day": 20230824, |
There was a problem hiding this comment.
I think this should only include the total seconds per day for this to keep it simple for now. We can expose more data later on. Should simplify your query a lot.
Geometrically
approved these changes
Sep 13, 2023
thesuzerain
added a commit
that referenced
this pull request
Dec 5, 2023
* playtime * other routes, improvements * fmt clippy * revs --------- Co-authored-by: Geometrically <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.