This repository has been archived by the owner on Aug 3, 2024. It is now read-only.
Replace project icon border #1295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96x96 icons are currently squished to 88x92 by the border style. This box-shadow replacement preserves the icon size while staying visually equivalent (rounded 4px border around left, top, and right).
Pretty now?
Pretty now?
|
Too messy, will open a clean PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modrinth/code#1544
Project pages with featured images and gallery-view search results have borders around their 96x96 icons, which squish them to 88x92. These box-shadow replacements preserve icon size while staying visually equivalent (rounded 4px border around left, top, and right).
edit: I've made a mess of this history because I'm limited to the browser and exploring options.