Skip to content
This repository has been archived by the owner on Aug 3, 2024. It is now read-only.

Extract Message banner component #1105

Merged
merged 5 commits into from
Aug 23, 2023
Merged

Conversation

falseresync
Copy link
Contributor

Screenshot 2023-04-19 205457

I have extracted this part of the layout into its own component. Additionally I have fixed the pesky border rounding.

@triphora
Copy link
Contributor

triphora commented Apr 19, 2023

The rounding was unintentional at first but I kinda think it's nice and unique
Also, flash message is kind of a confusing name, I was thinking this was something to do with Adobe. I would think "banner" or something might be better

@falseresync
Copy link
Contributor Author

I agree that there’re better names for it, though “flash messages” is used often for something like that in web dev (usually for messages delivered via the session, see Rails or Symfony for example). Banner seems a bit too vague though. If you have any other suggestions or arguments I am open

As for the border, I stand by my opinion, and would like a third voice

@Geometrically
Copy link
Member

I like this PR's border better

@falseresync falseresync changed the title Extract Flash message component Extract Message banner component Apr 22, 2023
# Conflicts:
#	pages/[type]/[id].vue
#	pages/search/[searchProjectType].vue
pages/[type]/[id].vue Outdated Show resolved Hide resolved
@triphora
Copy link
Contributor

Will be closed soon if comment isn't addressed and conflicts aren't resolved

@falseresync
Copy link
Contributor Author

ah, oi, I forgot, sorry; I was away from town. Going to fix soon!

# Conflicts:
#	pages/[type]/[id].vue
#	pages/search/[searchProjectType].vue
@triphora triphora merged commit 06cc400 into modrinth:master Aug 23, 2023
1 check passed
falseresync added a commit to falseresync/knossos that referenced this pull request Dec 6, 2023
commit d6ba3f3
Author: Brady <[email protected]>
Date:   Tue Dec 5 23:27:03 2023 -0330

    Add NeoForge to infer (modrinth#1443)

    * Add NeoForge inferring

    * Add check for if below 1.20.2

commit b453e2c
Author: Sasha Sorokin <[email protected]>
Date:   Wed Dec 6 12:21:14 2023 +1100

    Fallback to project type message on unknown types (modrinth#1470)

    This commit adds a fallback to getProjectTypeMessage function to return
    a generic project type whenever it encounters an unknown project type,
    ensuring there are no errors when the new project types are added.

commit 2d14e56
Author: Geometrically <[email protected]>
Date:   Tue Dec 5 12:13:27 2023 -0700

    New payouts system (modrinth#1456)

    * initial

    * finish withdraw page

    * Finish frontend

    * Fix UI a bit

    * tester fixes

commit 1f58aeb
Author: Carter <[email protected]>
Date:   Mon Dec 4 19:26:50 2023 -0800

    Oauth 2 Flow UI (modrinth#1440)

    * adjust existing sign-in flow

    * test fetching of oauth client

    * allow for apiversion override

    * getAuthUrl refactor

    * Adjust auth to accept complex url redirections

    * introduce scopes

    * accept oauth flow

    * rename login/oauth to authorize

    * conform to labrinth spec and oauth2 spec

    * use cute icons for scope items

    * applications pages

    * Modal for copy client secret on creation

    * rip out old state

    * add authorizations

    * add flow error state and implement feedback

    * implement error notifications on error

    * Client secret modal flow aligned with PAT copy

    * Authorized scopes now aligned with Authorize screen

    * Fix spelling and capitalization

    * change redirect uris to include the input field

    * refactor 2fa flow to be more stable

    * visual adjustments for authorizations

    * Fix empty field submission bug

    * Add file upload for application icon

    * Change shape of editing/create application

    * replace icon with Avatar component

    * Refactor authorization card styling

    * UI feedback

    * clean up spacing, styling

    * Create a "Developer" section of user settings

    * Fix spacing and scope access

    * app description and url implementations

    * clean up imports

    * Update authorization endpoint

    * Update placeholder URL in applications.vue

    * Remove app information from authorization page

    * Remove max scopes from application settings

    * Fix import statement and update label styles

    * Replace useless headers

    * Update pages/auth/authorize.vue

    Co-authored-by: Calum H. <[email protected]>

    * Update pages/auth/authorize.vue

    Co-authored-by: Calum H. <[email protected]>

    * Finish PR

    ---------

    Co-authored-by: Calum H. <[email protected]>
    Co-authored-by: Jai A <[email protected]>

commit 6d70ced
Author: Sasha Sorokin <[email protected]>
Date:   Tue Dec 5 13:48:12 2023 +1100

    Add Omorphia locale files loading (modrinth#1447)

    Implements loading of all locale files shipped with Omorphia package by
    globbing and registering them during the `vintl:extendOptions` hook.

    Also updated VIntl for Nuxt to ensure those files are properly loaded.
    Previous version of VIntl for Nuxt had a somewhat broken module ID
    tracking, preventing Omorphia locale files to be properly transformed
    during the build; at least on systems like Windows, don't know about
    *nix. The tracking approach was replaced in 1.8.0, and it seems to be
    working now.

commit accc53c
Author: Carter <[email protected]>
Date:   Wed Nov 29 10:56:17 2023 -0800

    Implement Editor MOD-349 (modrinth#1427)

    * Implement Editor

    * content oveflow fix for description

    * Description card fix

    * make everything fix in report modal

    * seperate report page with image upload

    * Bump Omorphia

    * Update pages/report.vue

    Co-authored-by: Emma Alexia <[email protected]>

    * suggested changes and cleanup

    * fix button spacing

    * clean up and replace report implementations

    * corepack fix

    * Remove ModalReport

    * image uploads for conversations

    * image uploading context for versions and threads

    * adjust information about thread messages

    * Update pages/report.vue

    Co-authored-by: Emma Alexia <[email protected]>

    * Adjust image upload imports

    * fix api changes for useImageUpload

    * correct report redirection uri

    * report button feedback

    * omorphia ver bump

    ---------

    Co-authored-by: Emma Alexia <[email protected]>

commit e4cb8b7
Author: Emma Alexia <[email protected]>
Date:   Mon Nov 20 18:57:06 2023 -0500

    Fix version editing on modpacks returning a "too large" error (modrinth#1455)

commit 61a2c36
Author: Emma Alexia <[email protected]>
Date:   Fri Nov 17 17:46:01 2023 -0500

    Fix grammatical issue in privacy policy (modrinth#1449)

    * Fix grammatical issue in privacy policy

    * Update privacy.vue

commit a7584d6
Author: Emma Alexia <[email protected]>
Date:   Mon Nov 13 20:30:06 2023 -0500

    Update omorphia to 0.6.7 (modrinth#1446)

    * Update omorphia to 0.6.7

    * shouldn't've been changed

commit f1f531c
Author: Geometrically <[email protected]>
Date:   Mon Nov 13 16:16:43 2023 -0700

    Fix links (modrinth#1445)

commit b5a275a
Author: BD103 <[email protected]>
Date:   Mon Nov 13 15:56:55 2023 -0500

    fix: remove sitemap property from robots.txt (modrinth#1441)

commit 82f0bdf
Author: Sasha Sorokin <[email protected]>
Date:   Sun Nov 12 17:49:05 2023 +0100

    Add handling for locale files parsing errors (modrinth#1408)

commit 23ccaac
Author: Emma Alexia <[email protected]>
Date:   Mon Oct 30 21:28:48 2023 -0400

    Fix outdated moderation warning (modrinth#1430)

commit 19828e9
Author: Mysterious_Dev <[email protected]>
Date:   Wed Oct 25 22:44:29 2023 +0200

    Update to omorphia 0.6.2 (modrinth#1418)

commit 8231c73
Author: Jakob <[email protected]>
Date:   Wed Oct 25 16:42:33 2023 -0400

    Fixed aria-label (modrinth#1403)

commit 85f639b
Author: Basil <[email protected]>
Date:   Wed Oct 25 14:41:29 2023 -0600

    Fixed report icons on version page when logged out (#1416) (modrinth#1417)

commit c471b6d
Author: Mysterious_Dev <[email protected]>
Date:   Wed Oct 25 22:40:58 2023 +0200

    Update to @vintl/how-ago 3.0.1 (modrinth#1413)

    * Update to @vintl/how-ago 3.0.1

    * Fix mistake

commit a363efc
Author: Prospector <[email protected]>
Date:   Tue Oct 24 12:46:56 2023 -0700

    new patreon logo (modrinth#1396)

commit 871a17a
Author: Mysterious_Dev <[email protected]>
Date:   Tue Oct 24 21:46:09 2023 +0200

    Convert error page to Composition API and fix condition for 404 Logo (modrinth#1405)

    * Convert error to Composition API

    * Fixed 404 logo not being displayed every time

commit fcfa508
Author: Mysterious_Dev <[email protected]>
Date:   Mon Oct 2 13:08:56 2023 +0200

    Fix convertion to Composition API for Avatar component (modrinth#1391)

    * Fix Convertion for Avatar component

    * Use ref for img

commit a6766ef
Author: Emma Alexia Triphora <[email protected]>
Date:   Sun Oct 1 16:22:05 2023 -0400

    Fix theme color not showing up properly in OpenGraph/Discord embeds (modrinth#1384)

commit 606b5ac
Author: chaos <[email protected]>
Date:   Sun Oct 1 13:21:44 2023 -0700

    Disable save & remove password button when no input password. (modrinth#1387)

commit 9acc463
Author: chaos <[email protected]>
Date:   Sun Oct 1 13:19:23 2023 -0700

    Fix dependencies list not updating on dependency remove. (modrinth#1388)

commit c4ddd08
Author: chaos <[email protected]>
Date:   Sun Oct 1 12:57:37 2023 -0700

    Fix license element deleting itself when pressing backspace. (modrinth#1389)

commit 5c7dd10
Author: Sasha Sorokin <[email protected]>
Date:   Sun Oct 1 21:45:21 2023 +0200

    Preserve whitespace in extracted translatable strings (modrinth#1390)

commit 3fa86cb
Author: Mysterious_Dev <[email protected]>
Date:   Sun Oct 1 17:47:47 2023 +0200

    Convert Avatar & Badge components to Composition API (modrinth#1386)

commit 4a74ee0
Author: Emma Alexia Triphora <[email protected]>
Date:   Sat Sep 30 18:45:53 2023 -0400

    Update legal pages, especially rules (modrinth#1373)

    * WIP rules update

    * Update

    * Run fix

    * Entirely unnecessary

    * Address comments

commit 8a8759b
Author: Mysterious_Dev <[email protected]>
Date:   Sat Sep 30 20:47:34 2023 +0200

    Add sessions translation to settings navstack (modrinth#1383)

commit f259072
Author: Sasha Sorokin <[email protected]>
Date:   Sat Sep 30 20:47:26 2023 +0200

    Post translation Sessions settings page fixes (modrinth#1382)

commit 3fd7429
Author: Sasha Sorokin <[email protected]>
Date:   Fri Sep 29 05:53:44 2023 +0200

    Remove unnecessary space in description on Sessions settings page (modrinth#1381)

commit f37c429
Author: Mysterious_Dev <[email protected]>
Date:   Fri Sep 29 04:44:36 2023 +0200

    Token Modal confirm for removal (modrinth#1375)

commit b924855
Author: Mysterious_Dev <[email protected]>
Date:   Fri Sep 29 04:43:53 2023 +0200

    Add translation keys for Sessions page (modrinth#1377)

    Co-authored-by: Sasha Sorokin <[email protected]>

commit 475d434
Author: Geometrically <[email protected]>
Date:   Mon Sep 25 22:28:48 2023 -0500

    Hide app promotion (modrinth#1376)

commit 05d568d
Author: Mysterious_Dev <[email protected]>
Date:   Sun Sep 24 21:35:34 2023 +0200

    Fix "Incorrect wording for expired pats" (modrinth#1378)

commit fc64719
Author: Emma Alexia Triphora <[email protected]>
Date:   Fri Sep 22 12:45:03 2023 -0400

    SEO cleanup (modrinth#1367)

    * SEO/Metadata cleanup

    May split rules changes into its own PR

    * Revert rules/terms changes as they are now on a separate branch

    * Update [searchProjectType].vue

    * Update terms.vue

commit bd4da4f
Author: Sasha Sorokin <[email protected]>
Date:   Sun Sep 17 03:07:52 2023 +0200

    Improve i18n-related SEO (modrinth#1366)

commit b88e63d
Author: Mysterious_Dev <[email protected]>
Date:   Sun Sep 10 18:25:33 2023 +0200

    Make .well-known/change-password redirect appropriately (modrinth#1360)

commit a85255d
Author: Mysterious_Dev <[email protected]>
Date:   Sun Sep 10 18:23:42 2023 +0200

    Fix: Mistake for profile translations (modrinth#1362)

commit 15c02e9
Author: Mysterious_Dev <[email protected]>
Date:   Sun Sep 10 18:21:00 2023 +0200

    Update Discord invite link to use official (modrinth#1363)

commit 54f55d4
Author: Emma Alexia Triphora <[email protected]>
Date:   Sat Sep 2 16:45:13 2023 -0400

    Fix dependency capitalization (modrinth#1351)

commit 568dc16
Author: Emma Alexia Triphora <[email protected]>
Date:   Sat Sep 2 09:42:00 2023 -0400

    Skip CI in all Crowdin commits (modrinth#1338)

commit 259b239
Author: Mysterious_Dev <[email protected]>
Date:   Sat Sep 2 15:41:32 2023 +0200

    Fix: Incorrect notification history link on dashboard (modrinth#1350)

commit 3033387
Author: MMK21Hub <[email protected]>
Date:   Sat Sep 2 14:40:02 2023 +0100

    Add `autocomplete` attributes to auth-related inputs (modrinth#1349)

commit d500c29
Author: Mysterious_Dev <[email protected]>
Date:   Sat Sep 2 15:39:26 2023 +0200

    Fix: Notifications are always unread on small windows (modrinth#1347)

commit 799d800
Author: Sasha Sorokin <[email protected]>
Date:   Sat Sep 2 15:38:27 2023 +0200

    Skip regenerate workflow on forks (modrinth#1344)

commit 5d34af6
Author: Sasha Sorokin <[email protected]>
Date:   Sat Sep 2 15:38:10 2023 +0200

    Make language label not translatable (modrinth#1343)

commit dca5b9f
Author: Mysterious_Dev <[email protected]>
Date:   Sat Sep 2 15:37:42 2023 +0200

    Support enter key for 2FA input field (modrinth#1341)

commit 75e075e
Author: Mysterious_Dev <[email protected]>
Date:   Sat Sep 2 15:37:04 2023 +0200

    Add translations for profile page (modrinth#1340)

    Co-authored-by: Sasha Sorokin <[email protected]>

commit 9895976
Author: Kxffie <[email protected]>
Date:   Sat Sep 2 08:33:52 2023 -0500

    Add query to embed of search pages (modrinth#1284)

commit 133367d
Author: Calum <[email protected]>
Date:   Sat Sep 2 14:31:59 2023 +0100

    Add "float: right|left" support for css. (modrinth#1208)

    Co-authored-by: Sasha Sorokin <[email protected]>

commit 5796428
Author: Emma Alexia Triphora <[email protected]>
Date:   Thu Aug 24 15:21:12 2023 -0400

    Miscellaneous CSS cleanup (and make the report modal look better) (modrinth#1334)

commit 51b07fc
Author: Sasha Sorokin <[email protected]>
Date:   Wed Aug 23 22:07:37 2023 +0200

    Add names of all languages on Crowdin (modrinth#1337)

commit d8f3364
Author: Sasha Sorokin <[email protected]>
Date:   Wed Aug 23 21:18:58 2023 +0200

    Enable all locales on staging instances (modrinth#1336)

commit a7c7234
Author: Emma Alexia Triphora <[email protected]>
Date:   Wed Aug 23 12:13:25 2023 -0400

    Fix project deletion going to a non-existent page (modrinth#1332)

commit f22f197
Author: Emma Alexia Triphora <[email protected]>
Date:   Wed Aug 23 12:02:45 2023 -0400

    Don't abbreviate moderation statistics (modrinth#1333)

commit 28a5806
Author: Emma Alexia Triphora <[email protected]>
Date:   Wed Aug 23 11:55:20 2023 -0400

    Remove defunct modpacks alpha notice setting (modrinth#1331)

commit df98167
Author: Nitrrine <[email protected]>
Date:   Wed Aug 23 20:40:45 2023 +0600

    Use Nuxt 3 documentation link instead of Nuxt 2 (modrinth#1327)

commit 06cc400
Author: falseresync <[email protected]>
Date:   Wed Aug 23 17:40:16 2023 +0300

    Extract Message banner component (modrinth#1105)

commit 66b47c0
Author: Nitrrine <[email protected]>
Date:   Wed Aug 23 20:39:30 2023 +0600

    Improve download button in changelog (modrinth#1311)

commit 40cb8db
Author: Sasha Sorokin <[email protected]>
Date:   Wed Aug 23 16:26:02 2023 +0200

    Move language nav menu item and hide it on prod (modrinth#1329)

commit 2454a03
Author: Geometrically <[email protected]>
Date:   Tue Aug 22 11:59:45 2023 -0400

    Fix broken dashboard (modrinth#1328)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants