FEAT-#308: Add monitor to each host in the cluster #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YarShev
reviewed
Jun 27, 2023
| hosts = MpiHosts.get() | ||
| info = MPI.Info.Create() | ||
| if hosts: | ||
| host_list = hosts.split(",") if hosts is not None else ["localhost"] |
There was a problem hiding this comment.
Suggested change
| host_list = hosts.split(",") if hosts is not None else ["localhost"] | |
| hosts = hosts.split(",") if hosts is not None else ["localhost"] |
Also, users should already pass hosts like a.b.c.d,a1.b1.c1.d1[,...]. Why do we need to call split here?
There was a problem hiding this comment.
"hosts" is another variable on the 160 row
"host_list" is required below to configure the special "--host" option for OpenMPI
| @@ -78,6 +78,22 @@ def log_operation(op_type, status): | |||
| ) | |||
|
|
|||
|
|
|||
| def is_internal_host_communication_supported(): | |||
There was a problem hiding this comment.
Suggested change
| def is_internal_host_communication_supported(): | |
| def is_shared_memory_supported(): |
| @@ -78,6 +78,22 @@ def log_operation(op_type, status): | |||
| ) | |||
|
|
|||
|
|
|||
| def is_internal_host_communication_supported(): | |||
| """ | |||
| Check if the Unidist on MPI support internal host communication | |||
There was a problem hiding this comment.
Suggested change
| Check if the Unidist on MPI support internal host communication | |
| Check if MPI supports shared memory. |
Comment on lines
+145
to
+142
| self.__host_rank_by_rank = defaultdict(None) | ||
| self.__host_by_rank = defaultdict(None) |
There was a problem hiding this comment.
Suggested change
| self.__host_rank_by_rank = defaultdict(None) | |
| self.__host_by_rank = defaultdict(None) | |
| self._host_rank_by_rank = defaultdict(None) | |
| self._host_by_rank = defaultdict(None) |
Add inline comments what is this for.
Signed-off-by: Kirill Suvorov <[email protected]>
Co-authored-by: Iaroslav Igoshev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 .black .git commit -sdocs/developer/architecture.rstis up-to-date