Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Iaroslav Igoshev <[email protected]>
  • Loading branch information
arunjose696 and YarShev committed Nov 6, 2023
1 parent 0fa4189 commit b9dfc65
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion unidist/core/backends/mpi/core/controller/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ def init():
atexit.register(_termination_handler)
signal.signal(signal.SIGTERM, _termination_handler)
signal.signal(signal.SIGINT, _termination_handler)
# Exit the init function in root only after monitor and worker loops have started.
# Exit the init function in root only after monitor and worker loops have started
mpi_state.comm.Barrier()
return
elif mpi_state.is_monitor_process():
Expand Down
2 changes: 1 addition & 1 deletion unidist/core/backends/mpi/core/monitor/loop.py
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ def monitor_loop():
# Once all workers excluding ``Root`` and ``Monitor`` ranks are ready to shutdown,
# ``Monitor` sends the shutdown signal to every worker, as well as notifies ``Root`` that
# it can exit the program.
# Barrier in monitor process to check if monitor loop has started
# Barrier to check if monitor process is ready to start the communication loop
mpi_state.comm.Barrier()
while True:
# Listen receive operation from any source
Expand Down
2 changes: 1 addition & 1 deletion unidist/core/backends/mpi/core/worker/loop.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ async def worker_loop():
# Once all workers excluding ``Root`` and ``Monitor`` ranks are ready to shutdown,
# ``Monitor` sends the shutdown signal to every worker so they can exit the loop.

# Barrier in worker process to check if worker loop has started
# Barrier to check if worker process is ready to start the communication loop
mpi_state.comm.Barrier()
while True:
# Listen receive operation from any source
Expand Down

0 comments on commit b9dfc65

Please sign in to comment.