Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for importing model configurations from YAML files #488

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Cufeyue
Copy link

@Cufeyue Cufeyue commented Nov 20, 2024


name: Pull Request
about: Create a pull request

Description

Background

The current project supports various ways to manage and configure models. However, there is no built-in support for importing model configurations from YAML files. YAML is a widely used format for configuration management due to its human-readable nature and ease of use.

Purpose

This pull request adds the ability to import model configurations from YAML files, providing a more flexible and user-friendly way to manage model configurations.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • [] Docstrings have been added/updated in Google Style
  • [] Documentation has been updated
  • Code is ready for review

@DavdGao DavdGao self-requested a review December 6, 2024 02:18
@rayrayraykk
Copy link
Collaborator

Please use pre-commit to format your code, thanks!

check python ast.........................................................Passed
sort simple yaml files...............................(no files to check)Skipped
check yaml...............................................................Passed
check xml................................................................Passed
check toml...............................................................Passed
check docstring is first.................................................Passed
check json...............................................................Passed
fix python encoding pragma...............................................Passed
detect private key.......................................................Passed
trim trailing whitespace.................................................Passed
Add trailing commas......................................................Passed
mypy.....................................................................Passed
black....................................................................Passed
flake8...................................................................Passed
pylint...................................................................Failed
- hook id: pylint
- exit code: 16

************* Module src.agentscope.manager._model
src/agentscope/manager/_model.py:5:0: C0411: standard import "from typing import Any, Union, Sequence" should be placed before "import yaml" (wrong-import-order)

------------------------------------
Your code has been rated at 10.00/10

Check package with Pyroma................................................Passed
  [**FAIL**] Please install pre-commit and format your code first. 
Error: Process completed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants