Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute python code fix #442

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zyzhang1130
Copy link
Contributor

@zyzhang1130 zyzhang1130 commented Sep 13, 2024


name: Pull Request
about: Create a pull request

Description

The current execute_python_code tool function uses exec() within a function, and any variables (including function definitions) created by the executed code are not automatically accessible within the scope of that code due to how local and global namespaces are managed. As a result, any function defined in the code cannot be executed properly.

Fix: explicitly manage the namespaces by providing a dictionary for the globals and locals parameters in the exec() function. Using the same dictionary for both globals and locals ensures variables and functions defined in code block are accessible within that code block.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@DavdGao DavdGao requested a review from rayrayraykk October 15, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant