Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter can now be used as a replacement to Model#toJSON() #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

filter can now be used as a replacement to Model#toJSON() #2

wants to merge 1 commit into from

Conversation

atticussterman
Copy link

Removes dependency on the model instance's existing toJSON method, allowing it to be used as a replacement.

@atticussterman
filter can now be used as a replacement to Model#toJSON()
8578191 
a tweak and a test

prevent crash on undefined val
@rschmukler
Copy link
Member

@atticussterman sorry for the delay and thanks for the PR. You can use modella.utils.clone instead of including it internally. If you use that, I'll accept the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atticussterman @rschmukler