fix(rest-api-model-server): fix compability #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odzhychko
force-pushed
the
fix/ktor-and-quarkus-compatibility
branch
from
ab4e0de to
b2adb22
Compare
|
We should bump to Quarkus 3 soon in any case. |
languitar
approved these changes
Nov 8, 2023
rest-api-model-server/src/test/kotlin/ReplicatedRepositoryInstantiationTest.kt
Outdated
Show resolved
Hide resolved
nkoester
approved these changes
Nov 8, 2023
odzhychko
force-pushed
the
fix/ktor-and-quarkus-compatibility
branch
from
b2adb22 to
b237e56
Compare
languitar
reviewed
Nov 8, 2023
rest-api-model-server/src/test/kotlin/ReplicatedRepositoryInstantiationTest.kt
Outdated
Show resolved
Hide resolved
odzhychko
force-pushed
the
fix/ktor-and-quarkus-compatibility
branch
from
b237e56 to
c736c46
Compare
odzhychko
force-pushed
the
fix/ktor-and-quarkus-compatibility
branch
from
c736c46 to
c822139
Compare
nkoester
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments in the changed file for details.
The problem is, that we want to use the platform release and that the platform release has broken (for some cases, like our Quarkus case) Ktor version.
The issue arises because of an older Quarkus version, which needs an older Kotlin version.