Skip to content

Commit

Permalink
feat: permission management and git clone performance
Browse files Browse the repository at this point in the history
MODELIX-1051: There is now a link next to the workspaces to manage the permissions on them.

MODELIX-1053: `git clone` is now executed in the separate workspace-job container and not in the
workspace-manager. The workspace-manager became unresponsive during that operation.
  • Loading branch information
slisson committed Dec 19, 2024
1 parent f39bf21 commit 2a345f2
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ spec:
value: "{{ include "modelix.fullname" . }}-wsclt-"
- name: WORKSPACE_CLIENT_IMAGE
value: "modelix/modelix-workspace-client:{{ .Values.imageTags.wsClient | default .Chart.AppVersion }}"
- name: "MODELIX_JWK_FILE"
value: /secrets/jwk/
- name: "MODELIX_JWK_FILE_INSTANCES_MANAGER"
value: /secrets/jwk/instancesmanager/private.pem
- name: MODELIX_WORKSPACE_SERVER
value: http://{{ include "modelix.fullname" . }}-workspace-manager:28104/
- name: WORKSPACE_DOCKER_REGISTRY
Expand Down Expand Up @@ -75,7 +75,7 @@ spec:
timeoutSeconds: 10
volumeMounts:
- name: "{{ include "modelix.fullname" . }}-instances-manager-rsa-keys"
mountPath: /secrets/jwk/wsmanager
mountPath: /secrets/jwk/instancesmanager
readOnly: true
restartPolicy: Always
volumes:
Expand Down
6 changes: 4 additions & 2 deletions helm/modelix/templates/common/model-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,10 @@ spec:
- env:
- name: jdbc_url
value: jdbc:postgresql://{{ include "modelix.fullname" . }}-db:5432/
- name: "MODELIX_JWK_FILE"
value: /secrets/jwk/
- name: "MODELIX_JWK_FILE_WORKSPACE_MANAGER"
value: /secrets/jwk/wsmanager/workspace-manager-public.pem
- name: "MODELIX_JWK_FILE_INSTANCES_MANAGER"
value: /secrets/jwk/instancesmanager/instances-manager-public.pem
{{- include "modelix.authorizationConfig" . | nindent 12 }}
image: "{{ .Values.dockerProxy.prefix }}modelix/model-server:{{ .Values.imageTags.model | default .Values.versions.modelix.core }}"
imagePullPolicy: IfNotPresent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,10 @@ spec:
value: "{{ include "modelix.fullname" . }}-"
- name: MODELIX_MAX_BODY_SIZE
value: "{{ .Values.maxBodySize }}"
- name: "MODELIX_JWK_FILE"
value: /secrets/jwk/
- name: "MODELIX_JWK_FILE_WORKSPACE_MANAGER"
value: /secrets/jwk/wsmanager/private.pem
- name: "MODELIX_JWK_FILE_INSTANCES_MANAGER"
value: /secrets/jwk/instancesmanager/instances-manager-public.pem
- name: MPS_BASEIMAGE_VERSION
value: {{ .Values.versions.modelix.vncBaseImage }}
- name: MPS_BASEIMAGE_NAME
Expand Down
4 changes: 2 additions & 2 deletions helm/modelix/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ fullnameOverride: ""

versions:
modelix:
workspaces: "0.5.0"
core: "10.1.0-pr1190-817f4549"
workspaces: "0.9.0"
core: "11.1.2"
kubernetes: "0.3.1"
vncBaseImage: "0.8.3"

Expand Down
4 changes: 2 additions & 2 deletions versions.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Modelix core version.
modelixCoreVersion=10.1.0-pr1190-817f4549
modelixCoreVersion=11.1.2
# Modelix Workspaces versions
modelixWorkspacesVersion=0.8.0
modelixWorkspacesVersion=0.9.0
vncBaseImageVersion=0.8.3

0 comments on commit 2a345f2

Please sign in to comment.