Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stub for mobius-pipeline #5

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix stub for mobius-pipeline #5

merged 1 commit into from
Nov 15, 2023

Conversation

HRashidi
Copy link
Contributor

@HRashidi HRashidi commented Nov 9, 2023

Summery:

Adding mypy config, so the mobius-pipeline types can be used directly from the source without adding stub for it.

@movchan74
Copy link
Contributor

But that runs mypy on the Mobius Pipeline as well. I'm not sure if that's what we want.

@HRashidi
Copy link
Contributor Author

HRashidi commented Nov 9, 2023

But that runs mypy on the Mobius Pipeline as well. I'm not sure if that's what we want.

Not really. The changes for the aana is this.
But depends on mobius_pipeline it either check the stub file (if we create them there) or just the code for mobius_pipeline.

So if we don't want to bother with mypy error for pipeline here, I can add the the stub files in the pipeline repo.
Still we need to change ignore_missing_imports to true, so missing imports like networkx which exists inside the pipeline stubs will ignored but not pipeline itself

@movchan74
Copy link
Contributor

changes for the aana is this.

I get a lot of messages from the Mobius Pipeline in "Problems" is VS Code.

@HRashidi
Copy link
Contributor Author

HRashidi commented Nov 9, 2023

changes for the aana is this.

I get a lot of messages from the Mobius Pipeline in "Problems" is VS Code.
If you mean mypy error I got them too. We need to merge the pipeline PR (mypy) to fix them. currently the pipelien has

@HRashidi HRashidi merged commit 42c7485 into main Nov 15, 2023
1 check passed
@HRashidi HRashidi deleted the hr/mypy_path branch November 15, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants