Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Video Processing #4

Merged
merged 7 commits into from
Nov 14, 2023
Merged

Basic Video Processing #4

merged 7 commits into from
Nov 14, 2023

Conversation

movchan74
Copy link
Contributor

Summary:
The SDK has been updated to include basic video processing features.

Key Changes:

  1. New Video Classes: Implemented VideoInput for request models and Video as a core representation of a video.
  2. Frame Extraction: Added basic frame extraction functionality using decord.
  3. Video Captioning: Introduced video captioning with the BLIP2 model.

Tests
Added tests for the new video classes and frame extraction.

evanderiel
evanderiel approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@evanderiel evanderiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Remember you might not be able to rely on asserts for runtime validation (although ATM I don't think it's a problem)

aana/models/core/media.py Show resolved Hide resolved
aana/models/core/media.py Show resolved Hide resolved
evanderiel
evanderiel approved these changes Nov 13, 2023
View reviewed changes
aana/configs/pipeline.py Show resolved Hide resolved
aana/models/core/media.py Outdated Show resolved Hide resolved
aana/utils/video.py Outdated Show resolved Hide resolved
aana/models/pydantic/video_input.py Outdated Show resolved Hide resolved
HRashidi
HRashidi approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@HRashidi HRashidi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some refactoring suggestions.
If it worth the time we can implement them.

aana/models/pydantic/image_input.py Show resolved Hide resolved
aana/models/pydantic/video_input.py Outdated Show resolved Hide resolved
aana/models/pydantic/video_input.py Show resolved Hide resolved
aana/tests/test_video_input.py Outdated Show resolved Hide resolved
HRashidi
HRashidi approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@HRashidi HRashidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@movchan74 movchan74 merged commit 318cf4d into main Nov 14, 2023
2 checks passed
@movchan74 movchan74 deleted the basic_video_processing branch November 14, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HRashidi HRashidi HRashidi approved these changes

@adaschevici adaschevici Awaiting requested review from adaschevici

@evanderiel evanderiel Awaiting requested review from evanderiel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@movchan74 @HRashidi @evanderiel