-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YouTube URL Enhancements and Video Verification after Download #26
Conversation
and improved errors for invalid video URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good but let's not use regex for parsing URLs
@evanderiel I removed VideoSource in favor of using yt-dlp for all video downloads. Please, take a look again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM
Just a question about the video downloader
If the video is not exist or the url is not valid, does it creates a empty file or throw exception. If possible we can use different error message in the UI.
@HRashidi If it cannot download the video, it will throw DeownloadException and nothing will be saved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please fix the usedforsecurity
parameter with md5 & resolve comments before merging
Summary:
This Pull Request enhances our YouTube integration by allowing more complex URL parameters and improving error handling for invalid video content.
Key Changes:
VideoReadingError
, ensuring that only valid video content is processed and error messages are more meaningful.