fix: express static content path and upgrade express to v4 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaello
commented
Apr 21, 2021
| @@ -558,13 +558,13 @@ | |||
| .core (@gridColumnWidth, @gridGutterWidth) { | |||
|
|
|||
| .spanX (@index) when (@index > 0) { | |||
| (~".span@{index}") { .span(@index); } | |||
| //(~".span@{index}") { .span(@index); } // not allowed in less-middleware > 1 | |||
There was a problem hiding this comment.
Visual inspection of the generated webpage does not seem affected of removing these lines of Less code.
There was a problem hiding this comment.
Hm, it seems it can be solved in this way: ept#18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed path to static content in
app.js(which is using Express.js).Upgrade Express.js from v3 to v4, which had some small breaking changes (most notable is that we now need to install all middleware explicitly). See Migrating from 3.x to 4.x for more info.
I tried to upgrade the Bootstrap less code to v3 with latest from bootstrap-less, but that was not successful and broke the interface. Bootstrap has since migrated to Sass, so we are not able to use latest version of Bootstrap anyway, but that is OK I guess.