Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a bug where (Signal) receiver_receipts could not be decoded with view_only FS. #958

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

i-infra
Copy link

@i-infra i-infra commented Feb 9, 2024

Use ViewAccountKey instead of AccountKey to use support check_receiver_receipt in view_only mode.

Motivation

Allows view-only FS accounts to process incoming Signal transactions.

In this PR

  • We decode the AccountKey only as a ViewAccountKey when we just need to access the view_private_key and not the spend_private_key field.

Test Plan

I tested it manually, ie - with a bot.

Future Work

  • Add test to ensure view-only decoding of receiver receipts is supported.
  • Document how/why to limit access to spend_private_key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant