Fix reproducible builds due to how derives were populated #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #455 +/- ##
==========================================
+ Coverage 88.40% 88.90% +0.49%
==========================================
Files 40 40
Lines 5667 5696 +29
==========================================
+ Hits 5010 5064 +54
+ Misses 657 632 -25 ☔ View full report in Codecov by Sentry. |
Previously `HashSet` was used to prevent duplicate entries in the computed derive attributes for bindgen generated code. The default hasher used in `HashSet` is randomly seeded on each process run to prevent HashDos. This random seeding resulted in changing the ordering of the resulted derive attributes. This changing order of the derive attributes prevented reproducible builds as the derived implementations would move around in the resultant binary. Now `BtreeSet` is used to prevent duplicate derives during code generation. This provides a consistent ordering of the derives.
nick-mobilecoin
force-pushed
the
nick/fix-reproducible-builds
branch
from
415b389 to
46fde17
Compare
eranrund
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
HashSetwas used to prevent duplicate entries in thecomputed derive attributes for bindgen generated code. The default
hasher used in
HashSetis randomly seeded on each process run toprevent HashDos. This random seeding resulted in changing the ordering
of the resulted derive attributes. This changing order of the derive
attributes prevented reproducible builds as the derived implementations
would move around in the resultant binary. Now
BtreeSetis used toprevent duplicate derives during code generation. This provides a
consistent ordering of the derives.