ISSUE-106: Fix "not keeping old RELS" #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was plenty wrong here when telling IMI to keep existing RELS-EXT relationships in place: 1.- We were forcing a new RELST-EXT datastream to be created in the batch object by adding the CMODEL 2.- We were opening to door to IMI's getDatastreamsforUpdate to take new RELS EXT in consideration. This unsets any existing RESL datastreams and also only adds CMODEL to the other Update modes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue?
See #106
There was plenty wrong here when telling IMI to keep existing RELS-EXT relationships in place:
1.- We were forcing a new RELST-EXT datastream to be created in the batch object by adding the CMODEL
2.- We were opening to door to IMI's getDatastreamsforUpdate to take new RELS EXT in consideration.
What is new?
This unsets any existing RESL datastreams and also only adds CMODEL to the other Update modes.