Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default testing branch for Julia tests #1221

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Oct 31, 2024

We recently re-organised branches in mmtk-julia and julia. Namely the previous master was renamed to dev, and we will use master for the version that works with Julia upstream. This PR extracts the default testing repos and branches, and changes the default testing branch for Julia.

@qinsoon qinsoon added the PR-extended-testing Run extended tests for the pull request label Oct 31, 2024
@qinsoon qinsoon requested a review from wks October 31, 2024 06:35
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon added this pull request to the merge queue Nov 1, 2024
Merged via the queue into mmtk:master with commit 3830168 Nov 1, 2024
34 checks passed
@qinsoon qinsoon deleted the fix-ci-tests-julia-branch branch November 1, 2024 03:03
@qinsoon qinsoon mentioned this pull request Nov 6, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 7, 2024
This PR changes the auto merge workflow. For each binding, the workflow
now allows inputs for base repo and base ref. This change is mostly for
the Julia binding which uses `dev` instead of `master` as the default
branch. #1221 only changed for the
correctness testing, this PR made corresponding changes for auto merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-extended-testing Run extended tests for the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants