forked from JuliaLang/julia
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin more references and expose some globally rooted symbols #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udesou
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
qinsoon
changed the title
Pin modules
Pin modules and expose some globally rooted symbols
Sep 2, 2024
qinsoon
changed the title
Pin modules and expose some globally rooted symbols
Pin more references and expose some globally rooted symbols
Sep 25, 2024
udesou
reviewed
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few more pining for types in the native heap, and exposes globally rooted symbols so we can trace them in the MMTk binding. With this PR, we can run moving Immix without transitively pinning
global_roots_table
. See mmtk/mmtk-julia#170.jl_gc_pin
jl_gc_pin
to pinBigFloat
for MPFRPTR_PIN
toOBJ_PIN
. Additionally addPTR_PIN
which handles cases for internal pointers.jl_codectx_t.global_targets
jl_codectx_t.PhiNodes
jl_cgval_t
jl_get_layout
(see Julia assumes perm alloc won't trigger GC mmtk-julia#172)libuv
's handle.jl_task_t.completion_future
(see unlock count must match lock count mmtk-julia#179)jl_codeinst_t
objects.jl_method_instance_t
objects.jl_module_t
objects.jl_task_t
objects.JL_GLOBALLY_ROOTED
symbols, such asnewly_inferred
,task_done_hook_func
.