Fixed loading avatars with interleaved buffers (#159) #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #159 (incidentally).
This PR resolves an issue where avatars that have been loaded as gLTF files that use interleaved buffers would be visually corrupted by the process of remapping the bone indices of child models to the parent model's bone indices because the code reading the buffer did not account for interleaved buffers and would read the data relating to other attributes as bone indices.
The change in this PR is to use accessors on the relevant classes rather than reading the array directly.
What kind of change does your PR introduce? (check at least one)
Does your PR fulfill the following requirements?