Packaging (#126) #127
Merged
Packaging (#126) #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusLongmuir
force-pushed
the
feature/packaging
branch
from
738110c to
a3090fb
Compare
MarcusLongmuir
force-pushed
the
feature/packaging
branch
from
a3090fb to
23797a9
Compare
|
Thank you very much for this! I should be able to find some time next week to restructure our whole software to this new packaged approach and will then - as discussed - also create a separately packaged third-party authenticator based on ExampleEnforcingUserAuthenticator.ts. As discussed, I'll likely send another PR your way mentioning this third-party package in README and removing the ExampleEnforcingUserAuthenticator.ts from this repository, as soon as I feel this new package is ready enough for other people to use. |
TheCodeTherapy
approved these changes
Apr 26, 2024
|
@MarcusLongmuir Approved but as I added 2 new commits myself, we'll also need approval from you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #126
This PR overhauls how the 3d-web-experience is packaged and adds two new packages (
3d-web-experience-server&3d-web-experience-client) to provide simplified entry points for client and server that wrap the underlying more modular packages.This should drastically simplify how easy it is to update to the latest version of the 3d-web-experience as previously the entrypoints were liable to change significantly with each version and leave users of the library with significant conflicts to resolve. Thanks to @tbergmueller for the feedback and suggestions on how to address this.
There have also been significant optimizations to the example mesh and animation assets which takes the initial download size for the client itself down from ~30MB to ~6MB. The files are now also compressed using DRACO and use the new
@mml-io/model-loaderpackage to solve the complexity of being able to load compressed assets.What kind of change does your PR introduce? (check at least one)
Does your PR fulfill the following requirements?