Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes flatten on dim=1 #40

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Fixes flatten on dim=1 #40

merged 2 commits into from
Oct 16, 2024

Conversation

mmcdermott
Copy link
Owner

Closes #39

@mmcdermott mmcdermott linked an issue Oct 16, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.78%. Comparing base (eaaa6bb) to head (5cc8569).
Report is 3 commits behind head on dev.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #40      +/-   ##
==========================================
+ Coverage   90.74%   90.78%   +0.04%     
==========================================
  Files           2        2              
  Lines         443      445       +2     
==========================================
+ Hits          402      404       +2     
  Misses         41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmcdermott mmcdermott marked this pull request as ready for review October 16, 2024 00:22
@mmcdermott mmcdermott merged commit ca70f5e into dev Oct 16, 2024
10 checks passed
@mmcdermott mmcdermott deleted the 39_flatten_on_dim1 branch October 16, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flatten does not work with target_dim=1
1 participant