adding TDRP file for beltrami validation - output_txt=TRUE. This can … #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…probably be refined in the future to only print what we need!
sjsprecious
requested review from
johnmauff,
mmbell,
sjsprecious and
supreethms1809
sjsprecious
reviewed
May 29, 2024
| // | ||
| // Type: boolean | ||
|
|
||
| output_txt = FALSE; |
There was a problem hiding this comment.
According to the PR title, is output_txt supposed to be set to TRUE here?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
=======================================
Coverage 33.15% 33.15%
=======================================
Files 51 51
Lines 17118 17118
=======================================
Hits 5675 5675
Misses 11443 11443 ☔ View full report in Codecov by Sentry. |
… VERY basic correctness check. Expect numbers to be different for each test case. Waiting for confirmation from John on ref.log file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…probably be refined in the future to only print what we need!