-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for #25 - Validation workflow (commented out until true reference files available) #114
base: thermo_asap
Are you sure you want to change the base?
Conversation
…netcdf analysis files
…ns, giving up sharing resources between them for now. Adding validaiton to build-and-run job
…eate space on cloud resource
…eltrami_build_run.yml. Removed fake samurai_XYZ_wind_analysis_ref.nc and ref_log from ncar_scripts/validation/beltrami until they can be replased with REAL reference files. These were just used for testing the workflow. Moved scripts for syncing public/development repos to ncar_scripts/sync_repos.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## thermo_asap #114 +/- ##
===============================================
- Coverage 32.55% 32.30% -0.25%
===============================================
Files 53 53
Lines 17847 17984 +137
===============================================
Hits 5810 5810
- Misses 12037 12174 +137 ☔ View full report in Codecov by Sentry. |
… increment, background, and analysis files to top level samurai directory. Also moved reduceNetCDF.py helper script to ncar_scripts/utils
My bad, I committed another feature before getting this PR approved. It's a bugfix for issue #111 (adding a writeNetCDF_thermo routine). We're now writing thermo netcdf output to the top level samurai directory. |
Also removed "fake" samurai_XYZ_wind_analysis_ref.nc from ncar_scripts/validation/beltrami until they can be replaced with REAL reference file. This also needs to be done to for the validation workflow to execute. Old samurai_XYZ_wind_analysis_ref.nc was just used for testing the workflow.
This has nothing to do with validation, but moved scripts for syncing public/development repos to ncar_scripts/sync_repos.