Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for #25 - Validation workflow (commented out until true reference files available) #114

Open
wants to merge 35 commits into
base: thermo_asap
Choose a base branch
from

Conversation

cenamiller
Copy link
Collaborator

@cenamiller cenamiller commented Sep 24, 2024

  1. Commented out validation setup and tests from .github/workflows/CPU_Beltrami_build_run.yml. (We'll need to uncomment lines 34-39 to enable validation):
     - name: Setup validation environment
     run: docker build -f docker/Dockerfile.validation -t samurai-validation .

    - name: Run Beltrami validation test 
     run: docker run --name test-container-validation --volumes-from test-container samurai-validation
  1. Also removed "fake" samurai_XYZ_wind_analysis_ref.nc from ncar_scripts/validation/beltrami until they can be replaced with REAL reference file. This also needs to be done to for the validation workflow to execute. Old samurai_XYZ_wind_analysis_ref.nc was just used for testing the workflow.

  2. This has nothing to do with validation, but moved scripts for syncing public/development repos to ncar_scripts/sync_repos.

…ns, giving up sharing resources between them for now. Adding validaiton to build-and-run job
…eltrami_build_run.yml. Removed fake samurai_XYZ_wind_analysis_ref.nc and ref_log from ncar_scripts/validation/beltrami until they can be replased with REAL reference files. These were just used for testing the workflow. Moved scripts for syncing public/development repos to ncar_scripts/sync_repos.
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 138 lines in your changes missing coverage. Please review.

Project coverage is 32.30%. Comparing base (2d99a40) to head (a03c92c).

Files with missing lines Patch % Lines
src/CostFunctionXYZ.cpp 0.00% 138 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           thermo_asap     #114      +/-   ##
===============================================
- Coverage        32.55%   32.30%   -0.25%     
===============================================
  Files               53       53              
  Lines            17847    17984     +137     
===============================================
  Hits              5810     5810              
- Misses           12037    12174     +137     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cenamiller cenamiller linked an issue Sep 24, 2024 that may be closed by this pull request
… increment, background, and analysis files to top level samurai directory. Also moved reduceNetCDF.py helper script to ncar_scripts/utils
@cenamiller
Copy link
Collaborator Author

My bad, I committed another feature before getting this PR approved. It's a bugfix for issue #111 (adding a writeNetCDF_thermo routine). We're now writing thermo netcdf output to the top level samurai directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beltrami Validation CI Workflow
1 participant