[Fix] error from v1 is not handled

CHANGELOG.md

@@ -1,5 +1,10 @@
 ## [Unreleased]
 
+## [v0.1.3](https://github.com/mmarusyk/easyship/tree/v0.1.3) - 2024-06-27
+
+### Fixed
+- Error from v1 is not handled by @mmarusyk
+
 ## [v0.1.2](https://github.com/mmarusyk/easyship/tree/v0.1.2) - 2024-06-24
 
 ### Features

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    easyship (0.1.2)
+    easyship (0.1.3)
       faraday (~> 2.9)
 
 GEM

lib/easyship/error.rb

@@ -7,6 +7,7 @@ module Easyship
   class Error
     # rubocop:disable Style::MutableConstant Style::MissingElse
     ERRORS = {
+      400 => Easyship::Errors::BadRequestError,
       401 => Easyship::Errors::InvalidTokenError,
       402 => Easyship::Errors::PaymentRequiredError,
       404 => Easyship::Errors::ResourceNotFoundError,

lib/easyship/errors/bad_request_error.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+require_relative 'client_error'
+
+module Easyship
+  module Errors
+    # Raised when Easyship returns the HTTP status code 400
+    class BadRequestError < ClientError; end
+  end
+end

lib/easyship/middleware/error_handler_middleware.rb

@@ -29,8 +29,6 @@ def body_error(body)
 
         if body.key?(:error) && body[:error].is_a?(Hash)
           format_body_error(body)
-        elsif body.key?(:errors) && body[:errors].is_a?(Array)
-          format_body_errors_array(body)
         elsif body.key?(:errors)
           format_body_errors(body)
         else
@@ -46,12 +44,10 @@ def format_body_error(body)
         body[:error]
       end
 
-      def format_body_errors_array(body)
-        { details: body[:errors], message: body[:errors].map { |error| error[:message] }.join(', ') }
-      end
-
       def format_body_errors(body)
-        { details: body[:errors], message: body[:errors] }
+        errors = Array(body[:errors])
+
+        { details: errors, message: errors.join(', ') }
       end
 
       def format_by_default(body)

lib/easyship/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Easyship
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 end

spec/easyship/client_spec.rb

@@ -34,4 +34,16 @@
       end
     end
   end
+
+  describe '#post' do
+    let(:path) { '/rate/v1/rates' }
+
+    context 'when invalid request body' do
+      it 'raises a ClientError' do
+        VCR.use_cassette('rate/v1/rates/invalid-body') do
+          expect { client.post(path, {}) }.to raise_error(Easyship::Errors::BadRequestError)
+        end
+      end
+    end
+  end
 end