-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/validators - MLTE-507, MLTE-150 #554
Open
sei-secheverria
wants to merge
48
commits into
master
Choose a base branch
from
feature/validators
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…json as required to better handle error.
…erate a standard and more informative exception if artifact or other model can't be serialized.
…ternal ConditionModel function, to better handle errors there.
…hon 3 is no longer needed separately from __eq__
…ide it. For DB serialization, Validator is stored as a JSON string, at least for now.
…result is a bool as expected
…s where we want to allow conditions to be created outside of a Value class.
…added checks to see that combination of None and existing args are valid
# Conflicts: # poetry.lock
…directly, to ensure it is always fixed
…when serializaing bool exp.
… special condition case
…or tracking purposes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructured Conditions to have a Validator inside that can guide the creation of the Condition, with specific arguments for bool expression, success message, etc, instead of depending on user of build_condition() figuring out the structure of the whole callback.
More specifically:
__json__()
method and allow json.dumps to work when serializing it (it was applied to Artifact), but in theory people could add it to their own complex Condition arguments if needed).