Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/load all values #310

Merged

Conversation

sebastian-echeverria
Copy link
Collaborator

Addresses #141 to allow loading all values from a given store with just one Value.load_all() call . More specifically

  • Added value_class attribute to Value model, which stores full path to class that implements that value (string with module plus class name).
  • Adds load_all_models() and load_all_models_with() methods to Artifact, to load all models of a given type in the given store.
  • Adds load_all() and load_all_with() methods to Value to load all values from a given store. They load all models from Artifact, and then dynamically load each Value from its module name and class, to use from_model to load them into Values.
  • Updated demos to showcase this new method.

Copy link
Collaborator

@turingcompl33t turingcompl33t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These a great updates @sebastian-echeverria, thanks for taking the lead on implementing this feature we've wanted for a while. LGTM.

@turingcompl33t turingcompl33t merged commit 1f4703b into mlte-team:master Dec 6, 2023
3 checks passed
@sebastian-echeverria sebastian-echeverria deleted the feature/load-all-values branch December 6, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants