Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report Rendering #289

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Report Rendering #289

merged 3 commits into from
Oct 16, 2023

Conversation

turingcompl33t
Copy link
Collaborator

This PR adds the ability to render MLTE reports in the web UI.

@sei-aderr
Copy link
Collaborator

This PR looks good to me too. It is not the final version so don't feel the need to nitpick it at all.

Everything loads into the page as expected for me. My one potential suggestion would be disabling each of the inputs so that the users can't edit the values in this temporary View mode, but not vital by any means

@turingcompl33t
Copy link
Collaborator Author

@sei-aderr thanks for the review. I was trying to figure out how to disable the UsaTextInput and UsaTextarea, but I couldn't find the correct property to do so. Do you know what this is?

@turingcompl33t turingcompl33t requested review from sei-aderr and krmaffey and removed request for sei-aderr October 15, 2023 11:50
krmaffey
krmaffey previously approved these changes Oct 15, 2023
View reviewed changes
Copy link
Contributor

@krmaffey krmaffey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kyle this is incredible. I don't know what property you need, but I can approve this PR!

@turingcompl33t turingcompl33t dismissed krmaffey’s stale review October 15, 2023 21:56

The merge-base changed after approval.

@sei-aderr
Copy link
Collaborator

You can disable the text input, and should work for any other input style field just like this. It looks like it doesn't adjust the color too much, just makes it non-selectable. If you want you can add some css for disabled elements to gray it out a bit more.

<UsaTextInput :model-value="form.summary.problem_type" disabled>

krmaffey
krmaffey approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@krmaffey krmaffey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for invalidating my earlier review @turingcompl33t

@turingcompl33t turingcompl33t merged commit 2df8540 into master Oct 16, 2023
6 checks passed
@turingcompl33t turingcompl33t deleted the feature/report-rendering branch October 16, 2023 19:59
@turingcompl33t turingcompl33t mentioned this pull request Oct 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krmaffey krmaffey krmaffey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate Report Rendering with MLTE UI
3 participants
@turingcompl33t @sei-aderr @krmaffey