-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QAS Demo - Flower Model #273
QAS Demo - Flower Model #273
Conversation
# Conflicts: # src/mlte/property/property.py
…ria/mlte into feature-new-properties # Conflicts: # demo-2/evidence.ipynb # demo-2/garden.py
… pvalue condition
# Conflicts: # src/mlte/evidence/evidence_metadata.py
# Conflicts: # mlte/validation/validated_spec.py
|
… the model interactively, but using saved results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sebastian, this demo is wonderful! It looks great to me, I think we are ready to merge it in. I discussed this with Kyle and he agrees, but we do have a request with regards to file structure.
Could you please change it so that this new demo is under the same folder as the old one? So the file structure will look something like this:
demo/
simple/
requirements.txt
requirements.ipynb
etc
scenario/
requirements.txt
requirements.ipynb
etc
I am not committed to those folder names (simple and scenario), if you have a better idea feel free to do that. My original thought was iris/ and flowers/ but I think it might be confusing since those are quite similar and the demos are distinct.
Agree with @krmaffey, just want to change the names of the directories now that we have two demonstrations, and this will be good to go! |
Thanks! Ok, restructured folders to match that. Used your same folder names, just changed the second one to "scenarios" instead of "scenario". I made a few, minor modifications: added a note recommending to install requirements.txt for the simple demo in the negotiation card notebook, and rearrenged the gitignore files a bit to be more self-contained in the demo and reduce duplication between both folders. Do note that if we move the model weights file for the "scenarios" demo, a minor change will be needed to the script that downloads it to download it from its new location. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thanks Sebastian!
This PR adds a second demo to the demo-2 folder with a flower model. Some notes and comments about it: