Skip to content

Commit

Permalink
Revert comments, update docs and dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
sei-aderr committed Jan 24, 2024
1 parent 40a725d commit 444d687
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 7 deletions.
9 changes: 9 additions & 0 deletions docs/docs/development.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,15 @@ $ npx gulp compile
$ npx gulp init
```

If there are issues with `npm install`, try this instead:

```bash
$ npm i --ignore-scripts
$ npm install
$ npx gulp compile
$ npx gulp init
```

Now the environment is set up and the front end can be run with the following command:

```bash
Expand Down
2 changes: 1 addition & 1 deletion mlte/frontend/nuxt-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"eslint-plugin-n": "^16.0.1",
"eslint-plugin-promise": "^6.1.1",
"eslint-plugin-vue": "^9.15.1",
"nuxt": "^3.4.2"
"nuxt": "^3.9.3"
},
"dependencies": {
"@babel/eslint-parser": "^7.22.9",
Expand Down
9 changes: 3 additions & 6 deletions mlte/frontend/nuxt-app/pages/report.vue
Original file line number Diff line number Diff line change
Expand Up @@ -442,12 +442,9 @@ async function fetchArtifact(
);
// TODO(Kyle): Error handling.
// Alex: Accessing status._value causes a weird error where it doesn't show any error, but the findings don't populate
// Commenting this out "fixes" that. Only seems to happen on my machine which is very odd. But status isn't an actual
// return from useFetch so error handling with have to happen differently
// if (status._value !== "success") {
// return null;
// }
if (status._value !== "success") {
return null;
}
return data._value;
}
Expand Down

0 comments on commit 444d687

Please sign in to comment.