Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: functional principal component analysis #45

Merged
merged 21 commits into from
Mar 28, 2024
Merged

feat: functional principal component analysis #45

merged 21 commits into from
Mar 28, 2024

Conversation

m-muecke
Copy link
Member

@m-muecke m-muecke commented Aug 24, 2023

Closes: #40

Currently only implemented for tfr type since tf package is missing implementation for irregular grids, see issue here: tidyfun/tf#80

@m-muecke m-muecke added the enhancement New feature or request label Aug 24, 2023
@m-muecke m-muecke self-assigned this Aug 24, 2023
@m-muecke m-muecke linked an issue Aug 24, 2023 that may be closed by this pull request
1 task
@m-muecke m-muecke marked this pull request as draft August 24, 2023 14:53
@sebffischer
Copy link
Member

@m-muecke What's the status here?

@m-muecke
Copy link
Member Author

@m-muecke What's the status here?

I was waiting for the cran submission for tf. Since that's done now, it can be finished in the next weeks.

@m-muecke m-muecke marked this pull request as ready for review March 26, 2024 16:50
@m-muecke m-muecke changed the title feat: added functional principal component analysis feat: functional principal component analysis Mar 26, 2024
Copy link
Member

@sebffischer sebffischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already looking great! Some things need to be addressed

R/PipeOpFPCA.R Outdated Show resolved Hide resolved
R/PipeOpFPCA.R Outdated Show resolved Hide resolved
R/PipeOpFPCA.R Outdated Show resolved Hide resolved
R/PipeOpFPCA.R Show resolved Hide resolved
R/PipeOpFPCA.R Outdated Show resolved Hide resolved
R/PipeOpFPCA.R Outdated Show resolved Hide resolved
@sebffischer
Copy link
Member

Maybe we can also mention in the docs how do apply it to regular data, i.e. first use the interpolation pipeop :)

@sebffischer sebffischer merged commit 27dfc44 into main Mar 28, 2024
@sebffischer sebffischer deleted the feat/pca branch March 28, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functional Principal Component Analysis
2 participants