Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to pdk 3, ruby 3 [spike] #774

Closed
wants to merge 4 commits into from
Closed

upgrade to pdk 3, ruby 3 [spike] #774

wants to merge 4 commits into from

Conversation

rrotter
Copy link
Member

@rrotter rrotter commented Dec 13, 2024 •
edited
Loading

So far…

  • manual changes:
    • remove .tool-versions
    • move local rake tasks to /rakelib
  • all other changes written by pdk
    • did not commit linter config changes
    • did not commit reformat of metadata.json
  • upgraded to pdk 3.4.0, reverted to 3.3.0 because 3.4.0 has a dependency conflict with librarian-puppet

Still need to:

  • get tests passing on ruby 3.2
  • fix puppet-lint
  • disable code coverage? (I suspect this is what's making tests take 20 minutes)
  • add standardrb

@rrotter rrotter force-pushed the upgrade_pdk branch 3 times, most recently from 362c035 to 7b64b58 Compare December 13, 2024 22:14
@rrotter rrotter changed the title Upgrade to PDK X.Y.Z [WIP] upgrade to pdk 3, ruby 3 Dec 13, 2024
@rrotter
upgrade to PDK 2.7.1
49b853f 
- manual changes:
  - remove .tool-versions
  - move local rake tasks to /rakelib
- all other changes written by `pdk`
  - did not commit linter config changes
  - did not commit reformat of metadata.json
@rrotter
upgrade to PDK 3.2.0, ruby 3.1
7fbdf19 
- use PDK templates except:
  - did not commit linter config changes
- bug fix: remove use of ipaddress legacy fact in public_ip.rb
- bump ruby version in .ruby-version, Dockerfile
@rrotter
upgrade to pdk 3.3.0
8c6bd1a 
- remove `networking:` from default_facts.yml because default fact
  merging is broken since at least PDK 3.0.1
- set librarian-puppet to '>= 5.0' so it doesn't get downgraded by gem
  requirement conflicts
- set pdk to '~> 3.3.0' so we'll get 3.4 when it no longer conflicts
  with the latest librarian-puppet
@rrotter
mlibrary/apache 7.1.1, ruby 3.2
be2d494
@rrotter rrotter changed the title upgrade to pdk 3, ruby 3 upgrade to pdk 3, ruby 3 [spike] Dec 17, 2024
@rrotter rrotter closed this Dec 17, 2024
@rrotter rrotter deleted the upgrade_pdk branch December 18, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rrotter