Website 38 investigate adding the ability to navigate via calendar in hours view #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate-adding-the-ability-to-navigate-via-calendar-in-Hours-View
added calendar expansion on clicking date range heading. Now I need to get the calendar view fixed under the heading, clean up the code, remove the repeated component, and see if we can sticky it on scroll.
moved the previous / next week component to its own component file and render it once at the top of the hours view versus multiple times at the top of each hours location. Also made the component sticky.
made the background color match the maize used throughout the rest of the interface and moved the sticky up 1px so there's not a gap.
…to-navigate-via-calendar-in-Hours-View
…to-navigate-via-calendar-in-Hours-View
User can now select week from calendar view, changed the previous and next week button to a link, added conditional highlighting for border of week.
next / previous week now changes month if moving to a different month. Selecting a week in a different month no longer selects the week index of the current month.
…to-navigate-via-calendar-in-Hours-View
Renamed the file to coincide with naming convention for panels. Added accessibility and keyboard navigation to calendar view. Updated the days positioning (sun, mon, tue, etc.) to better align with the columns.
…ia-calendar-in-Hours-View' of https://github.com/mlibrary/lib.umich.edu into WEBSITE-38-Investigate-adding-the-ability-to-navigate-via-calendar-in-Hours-View
Changed background color for calendar and working on consolidating actions.
refactored common logic into single utility function.
added esc close and instructions.
Moved the isVisible up to encapsulate entire calendar component.
SalazarJosh
had a problem deploying
to
previews
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✋ Wait!
Let's make sure your pull request is ready. Ask yourself...
✅ "Did I do a good job testing my own code?"
✅ "Is my code easy to read and understand?"
✅ "Have I written unit tests? Do the unit tests fully cover my code?"
✅ "Have I tested the repository's behavior to make sure my code didn't break anything?"
❎ "Did I include unrelated work that could be in its own pull request?"
Once you are ready, be sure to delete this
detailssection before opening your pull request.Overview
Talk about the intent and scope of the original issue. Go over the general changes that have been made between this branch and the branch the pull request will merge into. Displaying screenshots can help!
Add links to any documentation or issues that can help give more background information. Is the pull request related to a GitHub or JIRA issue? Link to them while using closing keywords, like so:
Anything else?
Optional. If appropriate, provide additional notes the reviewers should be made aware of. They can be about any "gotchas" or even changes that are expected to be made in the future, but are not applied to this pull request.
Testing
List instructions on how to test the pull request. Some examples: