Only check for solr alias changes on a timer #211
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
solr_cloud-connection
is purposefully chatty, not caching anything because during the admin cycle, you want to see your changes reflected immediatley and the number of operations is generally small.My use of uncached values (checking the name of the collection underlying an alias) on what turned out to be basically every call was disastrous.
This PR creates an instance of Concurrent::TimerTask that runs the check, and updates if needed, every 20 seconds.
Notable changes are:
config/initializers/solr_admin_cache.rb
Concurrent::Atom
instances in the Services module with everything elseload_local_config.rb
basically just calls#value
on the Services values.