Refactor BagReader as BagAdapter
#21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gAdapter.validate(); move FakeBagAdapter to bag_adapter
ssciolla
commented
Dec 19, 2024
| is_valid = False | ||
| print(e) | ||
|
|
||
| raise ValidationError(f"Validation failed with the following message: \"{str(e)}\"") |
There was a problem hiding this comment.
str() might not be needed here, but I do want to call bagit-python's __str__ method which captures all the error details in a single string. So being extra explicit I guess?
ssciolla
commented
Dec 19, 2024
Comment on lines
+20
to
+25
| uow.add_event(PackageNotVerified( | ||
| package_identifier=event.package_identifier, | ||
| tracking_identifier=event.tracking_identifier, | ||
| message=e.message | ||
| )) |
There was a problem hiding this comment.
I thought about adding an end-to-end test for this, but wasn't sure if I should do that on my own, or if we should wait until we have a handler for that event and some kind of notification component (email)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Do
is_validwith exception-raisingvalidatetests/fixtures/test_bagsBagReadertoBagAdapterand update step file and handlersPackageNotVerifiedevent