Merge pull request #11 from mlibrary/sms-handles-blank-files

Sms handles blank files

.github/pre-commit

@@ -14,12 +14,12 @@ rubyfiles=$(git diff --cached --name-only --diff-filter=ACM "*.rb" "Gemfile"  |
 
 # Standardize all ruby files
 echo "🧹 Formatting staged Ruby files using standardrb ($(echo $rubyfiles | wc -w | awk '{print $1}') total)"
-echo "$rubyfiles" | xargs docker-compose run --rm app bundle exec standardrb --fix
+echo "$rubyfiles" | xargs docker compose run -T --rm app bundle exec standardrb --fix
 
 # Add back the modified/prettified files to staging
 echo "$rubyfiles" | xargs git add
 
 echo "📋 Running tests with rspec"
-docker-compose run --rm app bundle exec rspec --format progress
+docker compose run -T --rm app bundle exec rspec --format progress
 
 exit 0

.gitignore

@@ -5,6 +5,7 @@ coverage/
 .bash_history
 .bundle/
 .cache/
+.solargraph.yml
 
 .ssh/*
 !.ssh/.keep

README.md

@@ -52,7 +52,7 @@ That's it. 🎉
 ## Running tests
 
 ```
-docker-compose run --rm app bundle exec rspec
+docker compose run --rm app bundle exec rspec
 ```
 
 ## Developer guidelines

init.sh

@@ -22,7 +22,7 @@ echo "🛠️ Set up sftp/sms directory for sms scripts"
 ./bin/sms/setup.sh
 
 echo "🚢 Build docker images"
-docker-compose build
+docker compose build
 
 echo "📦 Installing Gems"
-docker-compose run --rm app bundle
+docker compose run --rm app bundle

lib/aim/sms/sender.rb

@@ -31,9 +31,11 @@ def run
           @logger.info("Processing #{file}")
           sms_file = @sms_file_class.new(file)
           @sftp.get(sms_file.remote_file, sms_file.scratch_path)
-          message = Message.new(@file_class.read(sms_file.scratch_path))
-
           begin
+            message_text = @file_class.read(sms_file.scratch_path)
+            raise StandardError, "Message file is empty" if Message.empty?(message_text)
+            message = Message.new(message_text)
+
             response = @sender.send(message)
             @logger.info("status: #{response.status}, sid: #{response.sid}, to: #{response.to}, body: #{response.body}")
             summary[:num_files_sent] = summary[:num_files_sent] + 1
@@ -95,6 +97,10 @@ def send(msg)
     end
 
     class Message
+      def self.empty?(msg)
+        msg == ""
+      end
+
       def initialize(msg)
         @msg = msg.split("\n")
         @phone = TelephoneNumber.parse(@msg.first.strip, :US)

spec/aim/sms/sender_spec.rb

@@ -54,6 +54,14 @@
   before(:each) do
     @message = fixture("sms/sample_message.txt").split("\n")
   end
+  context ".empty?" do
+    it "is true if the message is nil" do
+      expect(described_class.empty?("")).to eq(true)
+    end
+    it "is false if the message is not empty" do
+      expect(described_class.empty?(@message)).to eq(false)
+    end
+  end
   subject do
     described_class.new(@message.join("\n"))
   end