Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #20 #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

cardboardcode
Copy link
Collaborator

@cardboardcode cardboardcode commented Oct 12, 2024

Purpose of Pull Request 🔖

This aims to fix the issue highlighted in #20 which was reproducable by doing the following:

Steps To Reproduce 📚

  1. Download rosbag2video:
cd $HOME
git clone https://github.com/mlaiacker/rosbag2video --depth 1 --single-branch --branch master && cd rosbag2video
  1. Ensure you have <ros1_bag_file_name> in the root of the repo.

  2. Run ROS 1 rosbag2video.py script:

source /opt/ros/noetic/setup.bash && python3 rosbag2video.py -t <ros1_image_topic_name> <ros1_bag_file_name>
  1. Run Step 3 again.

The cause of issue was determined to be due to having the output video file of the same name present after the first generation.

Summary 📑

  • Implement feature that automatically generates unique timestamps and appends it to the output video file name.

Remarks 💬

@mlaiacker May I get your help to do a quick 15 minute review and approve if you have the time?

@cardboardcode cardboardcode self-assigned this Oct 12, 2024
@cardboardcode cardboardcode changed the title Fix for #22 Fix for #20 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant