Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of Pull Request 🔖
This aims to fix the issue highlighted in #20 which was reproducable by doing the following:
Steps To Reproduce 📚
rosbag2video
:Ensure you have <ros1_bag_file_name> in the root of the repo.
Run ROS 1
rosbag2video.py
script:The cause of issue was determined to be due to having the output video file of the same name present after the first generation.
Summary 📑
Remarks 💬
@mlaiacker May I get your help to do a quick 15 minute review and approve if you have the time?