Skip to content

Commit

Permalink
add backend methods with integration tests
Browse files Browse the repository at this point in the history
  • Loading branch information
mkudlej committed May 7, 2024
1 parent d1e479e commit bc26be7
Show file tree
Hide file tree
Showing 3 changed files with 83 additions and 0 deletions.
12 changes: 12 additions & 0 deletions tests/integration/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,11 @@ def hits_metric(service):
return service.metrics.read_by(system_name='hits')


@pytest.fixture(scope='module')
def backend_hits_metric(backend):
return backend.metrics.read_by(system_name=('hits.' + str(backend['id'])))


@pytest.fixture(scope='module')
def method_params(service):
suffix = get_suffix()
Expand All @@ -233,6 +238,13 @@ def method(hits_metric, method_params):
cleanup(resource)


@pytest.fixture(scope='module')
def backend_method(backend_hits_metric, method_params):
resource = backend_hits_metric.methods.create(params=method_params)
yield resource
cleanup(resource)


def get_mapping_rule_pattern():
suffix = get_suffix()
pattern = f'test-{suffix}'.replace('_', '-')
Expand Down
51 changes: 51 additions & 0 deletions tests/integration/test_integration_backend_methods.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
import pytest

from threescale_api.errors import ApiClientError

from tests.integration import asserts

def test_list_methods(backend_hits_metric, backend_method):
assert len(backend_hits_metric.methods.list()) >= 1

def test_should_create_method(backend_method, method_params):
asserts.assert_resource(backend_method)
asserts.assert_resource_params(backend_method, method_params)


def test_should_not_create_method_for_custom_metric(backend_hits_metric, method_params):
resource = backend_hits_metric.methods.create(params=method_params, throws=False)
asserts.assert_errors_contains(resource, ['system_name'])


def test_should_friendly_name_be_required(backend_hits_metric):
resource = backend_hits_metric.methods.create(params={}, throws=False)
asserts.assert_errors_contains(resource, ['friendly_name'])


def test_should_raise_api_exception(backend_hits_metric):
with pytest.raises(ApiClientError):
backend_hits_metric.methods.create(params={})


def test_should_read_method(backend_method, method_params):
resource = backend_method.read()
asserts.assert_resource(resource)
asserts.assert_resource_params(resource, method_params)


def test_should_update_method(backend_method, updated_method_params):
resource = backend_method.update(params=updated_method_params)
asserts.assert_resource(resource)
asserts.assert_resource_params(resource, updated_method_params)


def test_should_delete_method(backend_hits_metric, updated_method_params):
resource = backend_hits_metric.methods.create(params=updated_method_params)
assert resource.exists()
resource.delete()
assert not resource.exists()


def test_should_list_methods(backend_hits_metric):
resources = backend_hits_metric.methods.list()
assert len(resources) == 1
20 changes: 20 additions & 0 deletions threescale_api/resources.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,13 @@ def url(self) -> str:
return self.parent.url + '/methods'


class BackendMethods(Methods):
def __init__(self, *args, entity_name='method', entity_collection='methods', per_page=None,
**kwargs):
super().__init__(*args, entity_name=entity_name,
entity_collection=entity_collection, per_page=per_page, **kwargs)


class ApplicationPlans(DefaultPlanClient):
def __init__(self, *args, entity_name='application_plan', entity_collection='plans', **kwargs):
super().__init__(*args, entity_name=entity_name,
Expand Down Expand Up @@ -1079,6 +1086,19 @@ def service(self) -> 'Service':
return self.metric.parent


class BackendMethod(Method):
def __init__(self, entity_name='system_name', **kwargs):
super().__init__(entity_name=entity_name, **kwargs)

@property
def service(self) -> 'Service':
raise AttributeError("'BackendMethod' object has no attribute 'service'")

@property
def backend(self) -> 'Backend':
return self.metric.parent


class Metric(DefaultResource):
def __init__(self, entity_name='system_name', **kwargs):
super().__init__(entity_name=entity_name, **kwargs)
Expand Down

0 comments on commit bc26be7

Please sign in to comment.