Bug fix for non-gif buddy icons #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mgmt api endpoint assumed image/gif content type. Instead try our best to detect it.
|
🎉 🌮 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The mgmt api endpoint assumed image/gif content type. Instead try our best to detect it.
If the content type can't be determined then it defaults to application/octet-stream
Testing
I tested by uploading gif and jpg buddy icons via pidgin and I'm able to fetch them from the api. PNG did not work for me, but it also didn't display in pidgin, so that format may not be supported.
Unit tests pass