-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose holomonic preview path in PathPlannerPath #443
Merged
mjansen4857
merged 6 commits into
mjansen4857:main
from
pjreiniger:expose_holomonic_starting_pose
Nov 3, 2023
+248
−13
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
258323b
Expose holomonic preview path
pjreiniger 6008cfd
Do suggested changes
pjreiniger 3d16be0
Update pathplannerlib/src/main/java/com/pathplanner/lib/path/PathPlan…
pjreiniger 642bdc7
Update pathplannerlib/src/main/native/cpp/pathplanner/lib/path/PathPl…
pjreiniger fc8631e
Add overload with pre-PR interface
pjreiniger 7f0d9c7
lint
pjreiniger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 changes: 85 additions & 0 deletions
85
pathplannerlib/src/test/java/com/pathplanner/lib/path/PathPlannerPathTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,85 @@ | ||
package com.pathplanner.lib.path; | ||
|
||
import static org.junit.jupiter.api.Assertions.assertEquals; | ||
import static org.junit.jupiter.api.Assertions.assertNotNull; | ||
|
||
import edu.wpi.first.math.geometry.Pose2d; | ||
import edu.wpi.first.math.geometry.Rotation2d; | ||
import edu.wpi.first.math.geometry.Translation2d; | ||
import java.util.ArrayList; | ||
import java.util.List; | ||
import org.junit.jupiter.api.Test; | ||
|
||
public class PathPlannerPathTest { | ||
private static final double EPSILON = 1e-6; | ||
|
||
@Test | ||
public void testDifferentialStartingPose() { | ||
PathPlannerPath path = | ||
new PathPlannerPath( | ||
List.of( | ||
new Translation2d(2, 1), | ||
new Translation2d(3.12, 1), | ||
new Translation2d(3.67, 1.00), | ||
new Translation2d(5.19, 1.00)), | ||
new ArrayList<>(), | ||
new ArrayList<>(), | ||
new ArrayList<>(), | ||
new PathConstraints(1, 2, 3, 4), | ||
new GoalEndState(0, Rotation2d.fromDegrees(0)), | ||
true, | ||
null); | ||
|
||
Pose2d initialPose = path.getStartingDifferentialPose(); | ||
assertNotNull(initialPose); | ||
assertEquals(2, initialPose.getX(), EPSILON); | ||
assertEquals(1, initialPose.getY(), EPSILON); | ||
assertEquals(180, initialPose.getRotation().getDegrees(), EPSILON); | ||
} | ||
|
||
@Test | ||
public void testHolomonicStartingPoseSet() { | ||
PathPlannerPath path = | ||
new PathPlannerPath( | ||
List.of( | ||
new Translation2d(2, 1), | ||
new Translation2d(3.12, 1), | ||
new Translation2d(3.67, 1.00), | ||
new Translation2d(5.19, 1.00)), | ||
new ArrayList<>(), | ||
new ArrayList<>(), | ||
new ArrayList<>(), | ||
new PathConstraints(1, 2, 3, 4), | ||
new GoalEndState(0, Rotation2d.fromDegrees(0)), | ||
true, | ||
Rotation2d.fromDegrees(90)); | ||
Pose2d initialPose = path.getPreviewStartingHolonomicPose(); | ||
assertNotNull(initialPose); | ||
assertEquals(2, initialPose.getX(), EPSILON); | ||
assertEquals(1, initialPose.getY(), EPSILON); | ||
assertEquals(90, initialPose.getRotation().getDegrees(), EPSILON); | ||
} | ||
|
||
@Test | ||
public void testHolomonicStartingPoseNotSet() { | ||
PathPlannerPath path = | ||
new PathPlannerPath( | ||
List.of( | ||
new Translation2d(2, 1), | ||
new Translation2d(3.12, 1), | ||
new Translation2d(3.67, 1.00), | ||
new Translation2d(5.19, 1.00)), | ||
new ArrayList<>(), | ||
new ArrayList<>(), | ||
new ArrayList<>(), | ||
new PathConstraints(1, 2, 3, 4), | ||
new GoalEndState(0, Rotation2d.fromDegrees(0)), | ||
true, | ||
null); | ||
Pose2d initialPose = path.getPreviewStartingHolonomicPose(); | ||
assertNotNull(initialPose); | ||
assertEquals(2, initialPose.getX(), EPSILON); | ||
assertEquals(1, initialPose.getY(), EPSILON); | ||
assertEquals(0, initialPose.getRotation().getDegrees(), EPSILON); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an overload for this constructor that doesn't need a previewStartingRotation? This constructor can be used for on-the-fly generation as well so it would be nice to not need to give it one.