fix: 🐛 setDefaultValueForUndefined clone defined value

mjancarik · Sep 27, 2024 · 4702ae4 · 4702ae4
1 parent 18a68e5
commit 4702ae4
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/packages/core/src/__tests__/utilsSpec.js b/packages/core/src/__tests__/utilsSpec.js
@@ -46,6 +46,12 @@ describe('utils function', () => {
 
       expect(original).toEqual({});
     });
+
+    it('should create copy of default value', () => {
+      const newObject = setDefaultValueForUndefined({}, ['a', 'b'], {});
+
+      expect(newObject.a !== newObject.b).toBeTruthy();
+    });
   });
 
   describe('bindWidgetToFunctions', () => {

diff --git a/packages/core/src/utils.js b/packages/core/src/utils.js
@@ -4,11 +4,20 @@ function createBoundedFunction(widget, originalFunction) {
   };
 }
 
+// @TODO in future use structuredClone instead of JSON.parse
+function clone(object) {
+  try {
+    return JSON.parse(JSON.stringify(object));
+  } catch (_) {
+    return object;
+  }
+}
+
 export function setDefaultValueForUndefined(object, keys, value = {}) {
   let objectClone = { ...object };
 
   keys.forEach((key) => {
-    objectClone[key] = objectClone[key] || value;
+    objectClone[key] = objectClone[key] || clone(value);
   });
 
   return objectClone;